Ideas

Refactor SessionHandlerRedisLocking

Running unit tests on a jenkins which doesn't have a redis resulted in an error because the SessionHandlerRedisLocking connects to redis already in constructor.

  • Avatar32.5fb70cce7410889e661286fd7f1897de Guest
  • Dec 12 2018
  • In review
  • Attach files
  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    December 12, 2018 13:19

    Mark Scherer's comment:
    It should indeed not do any business logic. I took a look into the class itself and it can be improved using a $connected attribute and lazy-connect then - or let the designated method handle it.